Skip to content

Fewer MulAddMul branches in Diagonal-triangular mul #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

Fewer MulAddMul branches in Diagonal-triangular mul #1272

merged 1 commit into from
Apr 23, 2025

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Apr 8, 2025

This reduces TTFX in Diagonal - triangular multiplications.

julia> using Random, LinearAlgebra

julia> A = rand(4,4); U = UpperTriangular(A); D = Diagonal(A);

julia> @time D * U;
  0.131110 seconds (239.39 k allocations: 12.162 MiB, 99.95% compilation time) # master
  0.102569 seconds (227.44 k allocations: 11.472 MiB, 99.94% compilation time) # this PR

If the Diagonal is on the right, the TTFX is almost identical, but allocations go down slightly.

julia> @time U * D;
  0.125025 seconds (221.82 k allocations: 11.252 MiB, 99.95% compilation time) # master
  0.127002 seconds (215.59 k allocations: 10.938 MiB, 12.06% gc time, 99.95% compilation time) # this PR

@jishnub jishnub added the ttfx The change pertains to first-call latency label Apr 8, 2025
@codecov
Copy link

codecov bot commented Apr 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.99%. Comparing base (5d3ef46) to head (59b33b1).
Report is 33 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1272      +/-   ##
==========================================
- Coverage   92.01%   91.99%   -0.02%     
==========================================
  Files          34       34              
  Lines       15488    15488              
==========================================
- Hits        14251    14248       -3     
- Misses       1237     1240       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub requested a review from dkarrasch April 8, 2025 17:15
@jishnub
Copy link
Member Author

jishnub commented Apr 20, 2025

Gentle bump

@jishnub jishnub merged commit fd115f4 into master Apr 23, 2025
3 of 4 checks passed
@jishnub jishnub deleted the jishnub/diag_tri_mul_nonzeroalpha branch April 23, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkarrasch dkarrasch dkarrasch approved these changes

Assignees

No one assigned

Labels

ttfx The change pertains to first-call latency

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jishnub @dkarrasch